CSPL-3723: Initial implementation for GenAI deployment with AIPlatform & AIService controllers - #3
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces functionality for worker group creation in the Ray builder along with a large number of supporting components and configuration files across the operator, including new storage clients, helm chart samples, RBAC and scorecard configurations. Key changes include:
- Implementation of a GenerateWorkerGroups function that groups model specifications into Ray worker groups.
- Addition of extensive controller reconciler logic, sidecar injections, and configuration management for the Splunk AI Operator.
- New test suites, helm charts, and RBAC configuration files to support a full, production-ready deployment.
Reviewed Changes
Copilot reviewed 87 out of 91 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/ai/raybuilder/workergroup.go | Implements GenerateWorkerGroups to aggregate models into worker groups. |
| pkg/ai/raybuilder/configmap_serve.go | Updates serve config processing with storage client instantiation. |
| pkg/ai/raybuilder/builder.go | Contains RayService build logic and worker/head pod templates. |
| (Other new files) | Includes various reconciler, RBAC, scorecard, helm and test files. |
Comments suppressed due to low confidence (1)
pkg/ai/raybuilder/builder.go:426
- The 'GPU_TYPE' environment variable is hard-coded to 'L40S' in the worker template; consider deriving this value dynamically from the model or node configuration to support heterogeneous GPU types.
Env: []corev1.EnvVar{
added 15 commits
July 6, 2025 10:22
rlieberman-splunk
previously approved these changes
Jul 7, 2025
rlieberman-splunk
previously approved these changes
Jul 16, 2025
vivekr-splunk
temporarily deployed
to
github-pages
August 7, 2025 05:14 — with
GitHub Pages
Inactive
vivekr-splunk
temporarily deployed
to
github-pages
August 12, 2025 07:58 — with
GitHub Pages
Inactive
vivekr-splunk
temporarily deployed
to
github-pages
August 15, 2025 18:54 — with
GitHub Pages
Inactive
Signed-off-by: vivek.name: "Vivek Reddy <user.email: vivekr@splunk.com>
vivekr-splunk
temporarily deployed
to
github-pages
August 19, 2025 00:39 — with
GitHub Pages
Inactive
vivekr-splunk
had a problem deploying
to
github-pages
August 22, 2025 05:14 — with
GitHub Pages
Error
vivekr-splunk
temporarily deployed
to
github-pages
August 22, 2025 05:15 — with
GitHub Pages
Inactive
vivekr-splunk
had a problem deploying
to
github-pages
August 26, 2025 17:48 — with
GitHub Pages
Failure
added 2 commits
September 1, 2025 23:20
vivekr-splunk
temporarily deployed
to
github-pages
September 2, 2025 06:21 — with
GitHub Pages
Inactive
vivekr-splunk
temporarily deployed
to
github-pages
September 5, 2025 19:47 — with
GitHub Pages
Inactive
rlieberman-splunk
temporarily deployed
to
github-pages
September 8, 2025 15:21 — with
GitHub Pages
Inactive
rlieberman-splunk
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the foundational code to enable GenAI deployments using the new
AIPlatformandAIServicecustom resources. It focuses on supporting SAIA (Splunk AI Assistant) initially, while keeping the design extensible to add SECA and future features.Key Highlights
✅ AIPlatform Custom Resource & Controller
AIPlatformSpec and Status fields to manage the end-to-end lifecycle of GenAI workloads.AIPlatformcontroller to reconcile all required services and components.✅ AIService Custom Resource & Controller
AIServiceas an internal component managed byAIPlatform.✅ Supporting Services & Utilities
✅ Unit Tests
✅ Manual Validation
Manually tested with an
AIPlatformCR to verify that:✅ Documentation
What’s Not in This PR
How to Test
AIPlatformandAIService.AIPlatformCR with SAIA enabled.Next Steps