-
Notifications
You must be signed in to change notification settings - Fork 127
CSPL-3964: Upgrading operator-sdk #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 20343950634Details
💛 - Coveralls |
8a01a85 to
b9cfd53
Compare
| - develop | ||
| - main | ||
| - feature** | ||
| - CSPL-3964_Upgrade-operator-sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to remove this line before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will approve once this is removed. Looks good otherwise!
kubabuczak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't you apply changes listed in Operator SDK upgrade guides?
@kubabuczak Everything should be addressed within this PR from all migrations. Not everything from those version docs are relevant for us (i.e. webhooks, linting, testing that we already have implementation for, etc) as was pointed out in the prior PR. Is there something specifically you expect to see from these migrations that aren't addressed? |
… as well as removing some uneccessary env vars added to the workflows.
b9cfd53 to
5fcc685
Compare
Description
Upgrading operator-sdk to version 1.41.1 and Golang version to 1.24.4. There were some linting changes that trickled through, but were very minor, so just decided to leave in. Thankfully, there weren't any breaking changes, so this was pretty straightforward other than some go mod changes (ran
go mod tidyto resolve). This will help resolve security vulnerability: https://splunk.atlassian.net/browse/VULN-42799Key Changes
The main updates are in the
.envandDockerfileTesting and Verification
Ran operator locally, installed operator on EKS cluster, and ran unit tests. Added this branch to be picked up by integration testing, so will monitor outputs of that.
Related Issues
PR Checklist