Fixes: Enhance Kotlin Support for Suppliers, Functions, and Consumers #1277 #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoupard
force-pushed
the
feat/kotlin-support-enhancement
branch
3 times, most recently
from
b8e40f1 to
5224936
Compare
|
About the DCO task fail, I have update the email to [email protected]. |
It has to container your legal name - full legal name. |
added 4 commits
May 13, 2025 01:08
This commit introduces a comprehensive suite of tests to cover all possible declarations of Kotlin functions, consumers, and suppliers within the `spring-cloud-function-kotlin` module. The primary goal of these tests is to explore the various declaration combinations and identify potential areas for improvement and enhanced support in the framework. Signed-off-by: Adrien Poupard <[email protected]>
This commit refactors the `spring-cloud-function-context` to comprehensively handle all combinations of possible declarations for Kotlin functions, consumers, and suppliers. This improves the framework's ability to correctly interpret and manage different Kotlin functional styles. Signed-off-by: Adrien Poupard <[email protected]>
This commit adds new unit tests to verify the core logic for Kotlin arity handling and wrapper mechanisms. These tests cover various scenarios including catalogue registration and native type casting for consumers, functions, and suppliers. Signed-off-by: Adrien Poupard <[email protected]>
Signed-off-by: Adrien Poupard <[email protected]>
apoupard
force-pushed
the
feat/kotlin-support-enhancement
branch
from
5224936 to
8a8ef5a
Compare
|
Done, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This merge request aims to enhance and solidify Kotlin support within Spring Cloud Function. It addresses several identified issues related to the handling of various Kotlin features, including
suspendfunctions,Flowtypes, and different functional arities/signatures for Suppliers, Functions, and Consumers.Recent compatibility testing highlighted a number of scenarios where Kotlin function declarations were not being processed as expected, leading to runtime exceptions and test failures. This MR introduces fixes and improvements to the
spring-cloud-function-contextto better interpret and manage diverse Kotlin functional styles.Key Changes:
spring-cloud-function-contexthas been refactored to more comprehensively handle various declaration combinations for Kotlin functions, consumers, and suppliers.spring-cloud-function-kotlinmodule. These tests cover a wide range of Kotlin function, consumer, and supplier declarations to ensure their correct behavior and to help identify areas for further improvement.Summary of Addressed Issues from Testing:
The changes in this MR specifically target issues observed during testing, such as:
UnsupportedOperationExceptionandNullPointerExceptionrelated tosuspendfunction handling.ClassCastExceptionwhen dealing withkotlinx.coroutines.flow.Flowandorg.springframework.messaging.Messagetypes.DecodingExceptionfor certain reactive types likeFlow.By addressing these points, this MR significantly improves the robustness and usability of Spring Cloud Function for Kotlin developers, aiming to provide a more seamless and first-class experience.