Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MapStruct reporting policy change (from issue #157) #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joaobertholino
Copy link

@joaobertholino joaobertholino commented Oct 16, 2024

Change in the reporting policy of Mapper interfaces, suppressing log warnings regarding attributes not mapped by MapStruct.
Change regarding issue #157

image

…og warnings for attributes not mapped by MapStruct.
@joaobertholino joaobertholino changed the title fix: Implementation of a new reporting policy that aims to suppress l… fix: MapStruct reporting policy change (from issue #157) Oct 16, 2024
@joaobertholino joaobertholino marked this pull request as draft October 16, 2024 23:18
@joaobertholino joaobertholino marked this pull request as ready for review October 16, 2024 23:20
@arey
Copy link
Member

arey commented Nov 8, 2024

Thanks @joaobertholino for your proposition.
I prefer to check warning by warning if there are no omissions. Are you ok to check that please?
For example, this afternoon, @misto has fixed two warnings in their PR: #172
If the property is missing at one side, we could use the @Mapping(target = "comments", ignore = true) syntax
See https://www.baeldung.com/mapstruct-ignore-unmapped-properties

@arey arey added the bug label Nov 8, 2024
@arey arey self-requested a review November 9, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants