GH-4452 Added Builder pattern support for DeepSeekAssistantMessage
#4453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eekAssistantMessage` and included corresponding unit tests. Signed-off-by: Sun Yuhan <[email protected]>
Signed-off-by: Sun Yuhan <[email protected]>
…tMessage` and modify related references to use `new` instead. Signed-off-by: Sun Yuhan <[email protected]>
|
Hi @ericbottard , I've made some adjustments in the current PR, implementing the solution we finalized in #4457. Could you please help review it again? Thanks so much! |
|
Merged on main via 7d0aff0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue,
DeepSeekAssistantMessagealso requires comprehensive Builder pattern support.This PR follows the approach proposed in #3529 and includes the following changes:
AssistantMessageBuilder to support inheritance in theDeepSeekAssistantMessageBuilder.DeepSeekAssistantMessage.toStringmethodFixes #4452