Change RestTemplateBuilder redirections at HttpComponentsClientHttpRequestFactory to FOLLOW_WHEN_POSSIBLE #43778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
panic08
force-pushed
the
test-rest-template-redirect-defaults
branch
from
c7f809c to
a1c56a5
Compare
…questFactory to FOLLOW_WHEN_POSSIBLE Signed-off-by: Andrey Litvitski <[email protected]>
panic08
force-pushed
the
test-rest-template-redirect-defaults
branch
from
a1c56a5 to
191cd0b
Compare
snicoll
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our main problem is that
RestTemplatehas a default redirect status ofFOLLOW_WHEN_POSSIBLE. When we buildRestTemplateBuilderand want to use Apache HttpComponents as a basis, for some reason we checkhttpClientOptionsforHttpClientOption.ENABLE_REDIRECTS, otherwise we set it to false, which is wrong.The solution to this problem I saw was to set
builder.redirects(Redirects.FOLLOW_WHEN_POSSIBLE);the defaultif (httpClientOptions != null).Closes: #43431