Skip to content

Remove unused AbstractRestTemplateBuilderRequestFactoryConfigurationTests #44948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

thecooldrop
Copy link
Contributor

@thecooldrop thecooldrop commented Mar 29, 2025

The abstract base test behaviour is well tested using the class AbstractClientHttpRequestFactoriesTests, thus can safely be removed.

Closes #42864

…ctoryConfigurationTests

The abstract base test behaviour is well tested using the class
AbstractClientHttpRequestFactoriesTests, thus can safely be removed.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 29, 2025
@wilkinsona
Copy link
Member

Thanks for the PR, @thecooldrop. Please update the base branch to 3.4.x and sign the commit.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Apr 2, 2025
@wilkinsona wilkinsona changed the title Remove unused abstract base test AbstractRestTemplateBuilderRequestFactory (#42864) Remove unused AbstractRestTemplateBuilderRequestFactoryConfigurationTests Apr 2, 2025
@snicoll
Copy link
Member

snicoll commented Apr 10, 2025

@thecooldrop please see above.

@philwebb philwebb added the status: on-hold We can't start working on this issue yet label Apr 10, 2025
@snicoll
Copy link
Member

snicoll commented Apr 17, 2025

@thecooldrop sorry, but for trivial changes like this we prefer to keep them out of the way. I took care of removing the class.

@snicoll snicoll closed this Apr 17, 2025
@snicoll snicoll added status: superseded An issue that has been superseded by another and removed status: waiting-for-feedback We need additional information before we can continue status: on-hold We can't start working on this issue yet status: waiting-for-triage An issue we've not yet triaged labels Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbstractRestTemplateBuilderRequestFactoryConfigurationTests doesn't appear to be used
5 participants