Skip to content

MongoDB's dependency management is missing Kotlin coroutine driver modules #45018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nenros
Copy link
Contributor

@nenros nenros commented Apr 7, 2025

Currently to keep same version of coroutine driver we need to make nasty trick

val mongodbVersion: String? = dependencyManagement.importedProperties["mongodb.version"]

dependencies {
    implementation("org.mongodb:mongodb-driver-kotlin-coroutine:${mongodbVersion}")
    implementation("org.mongodb:bson-kotlin:${mongodbVersion}")
}

It would be much easier to keep that version in spring bom.

Currently to keep same version of coroutine driver we need to make nasty trick

```kotlin 
val mongodbVersion: String? = dependencyManagement.importedProperties["mongodb.version"]

dependencies {
    implementation("org.mongodb:mongodb-driver-kotlin-coroutine:${mongodbVersion}")
    implementation("org.mongodb:bson-kotlin:${mongodbVersion}")
}
```

It would be much easier to keep that version in spring bom.


Signed-off-by: Bartosz Markowski <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 7, 2025
@snicoll snicoll changed the title Add kotlin coroutine driver to mongodb group. Add kotlin coroutine driver to MongoDB's dependency management Apr 8, 2025
@snicoll
Copy link
Member

snicoll commented Apr 8, 2025

mongodb-driver-kotlin-coroutine has been introduced in MongoDB 4.10.0 so one can argue it's an oversight in our dependency management. If we want to fix this, we could add the missing bits up to Spring Boot 3.3.x.

Flagging for team attention to see what the rest of the team thinks.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Apr 8, 2025
@nenros
Copy link
Contributor Author

nenros commented Apr 8, 2025

I would be really gratefull if it can be added in next 3.3.x release

@philwebb philwebb added type: bug A general bug and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Apr 10, 2025
@philwebb philwebb added this to the 3.3.x milestone Apr 10, 2025
@philwebb philwebb changed the title Add kotlin coroutine driver to MongoDB's dependency management MongoDB's dependency management is missing Kotlin coroutine driver modules Apr 10, 2025
@snicoll snicoll self-assigned this Apr 10, 2025
@snicoll snicoll modified the milestones: 3.3.x, 3.3.11 Apr 11, 2025
snicoll pushed a commit that referenced this pull request Apr 11, 2025
@snicoll snicoll closed this in b40fb62 Apr 11, 2025
@snicoll
Copy link
Member

snicoll commented Apr 11, 2025

@nenros thanks very much for making your first contribution to Spring Boot. FTR we order dependencies alphabetically for easier management, I've polished that in 6d36864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants