Enable AOT repository generation by default #3904
Conversation
…AOT is enabled or not Signed-off-by: Hyunsang Han <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
|
|
||
| GenericApplicationContext context = new GenericApplicationContext(); | ||
|
|
||
| System.setProperty(AotDetector.AOT_ENABLED, "true"); |
There was a problem hiding this comment.
Setting system properties can be achieved via @SetSystemProperty(…) to avoid leaking system properties state if the test fails.
There was a problem hiding this comment.
@mp911de
Thank you for your feedback! I completely understand your point and I agree with you.
To use @SetSystemProperty(…) and @ClearSystemProperty, we need to add the junit-pioneer dependency.
Do you think it would be a good idea to include junit-pioneer in this project?
There was a problem hiding this comment.
We have it already in Spring Data MonoDB, feel free to include it in JPA as well.
| } | ||
|
|
||
| @Test // GH-3899 | ||
| void repositoryProcessorShouldNotEnableAotRepositoriesByDefaultWhenAotIsDisabled() { |
There was a problem hiding this comment.
You could use @ClearSystemProperty here
| System.setProperty(AotDetector.AOT_ENABLED, "true"); | ||
|
|
||
| try { | ||
| JpaRepositoryContributor contributor = new JpaRepositoryConfigExtension.JpaRepositoryRegistrationAotProcessor() |
There was a problem hiding this comment.
This snippet could be extracted into a utility method within the test class to not repeat ourselves.
There was a problem hiding this comment.
Thank you. I created a private method and refactored these.
| System.setProperty(AotDetector.AOT_ENABLED, "true"); | ||
|
|
||
| try { | ||
| MockPropertySource propertySource = new MockPropertySource() |
There was a problem hiding this comment.
This could be handled by system properties as well as GenericApplicationContext creates StandardEnvironment that utilizes system properties and system environment for property sources. That would simplify the test arrangement.
There was a problem hiding this comment.
Good point. I changed to use SetSystemProperty for this!
mp911de
added
type: enhancement
Signed-off-by: Hyunsang Han <[email protected]>
Signed-off-by: Hyunsang Han <[email protected]>
Signed-off-by: Hyunsang Han <[email protected]>
mp911de
changed the title
|
Thank you for your contribution. That's merged and polished now. |
Signed-off-by: Hyunsang Han <[email protected]> Original pull request: #3904 Closes #3899
Resolves: #3899
Currently, to leverage AOT optimized repositories on the JVM with Spring Data JPA, users need to explicitly set both
spring.aot.enabled=trueandspring.aot.repositories.enabled=true.This change updates the behavior so that if Spring Framework's AOT processing is active (e.g.,
spring.aot.enabled=trueis set, or the application is being prepared for a native image), Spring Data JPA's AOT repository generation (spring.aot.repositories.enabled) will also be enabled by default.