CompositeCodec constructors require at least one delegate #10189
+136
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
Jul 3, 2025
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Outdated
Show resolved
Hide resolved
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Outdated
Show resolved
Hide resolved
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Outdated
Show resolved
Hide resolved
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Outdated
Show resolved
Hide resolved
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Outdated
Show resolved
Hide resolved
cppwfs
changed the title
cppwfs
changed the title
cppwfs
force-pushed
the
SI-CLEANUP-COMPOSITE_CODEC
branch
from
182d2d9 to
77397a3
Compare
artembilan
requested changes
Jul 3, 2025
...ation-core/src/test/java/org/springframework/integration/codec/kryo/CompositeCodecTests.java
Outdated
Show resolved
Hide resolved
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Outdated
Show resolved
Hide resolved
artembilan
requested changes
Jul 4, 2025
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Outdated
Show resolved
Hide resolved
mrpiggi
suggested changes
Jul 4, 2025
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Show resolved
Hide resolved
artembilan
requested changes
Jul 7, 2025
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Outdated
Show resolved
Hide resolved
...p/src/test/java/org/springframework/integration/ip/tcp/connection/TcpMessageMapperTests.java
Outdated
Show resolved
Hide resolved
cppwfs
force-pushed
the
SI-CLEANUP-COMPOSITE_CODEC
branch
2 times, most recently
from
1d1e239 to
539236d
Compare
artembilan
requested changes
Jul 11, 2025
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Show resolved
Hide resolved
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Show resolved
Hide resolved
...ation-core/src/test/java/org/springframework/integration/codec/kryo/CompositeCodecTests.java
Outdated
Show resolved
Hide resolved
...ation-core/src/test/java/org/springframework/integration/codec/kryo/CompositeCodecTests.java
Outdated
Show resolved
Hide resolved
...ation-core/src/test/java/org/springframework/integration/codec/kryo/CompositeCodecTests.java
Outdated
Show resolved
Hide resolved
...p/src/test/java/org/springframework/integration/ip/tcp/connection/TcpMessageMapperTests.java
Outdated
Show resolved
Hide resolved
cppwfs
force-pushed
the
SI-CLEANUP-COMPOSITE_CODEC
branch
2 times, most recently
from
8f381d9 to
40070c4
Compare
artembilan
requested changes
Jul 11, 2025
spring-integration-core/src/main/java/org/springframework/integration/codec/CompositeCodec.java
Outdated
Show resolved
Hide resolved
cppwfs
force-pushed
the
SI-CLEANUP-COMPOSITE_CODEC
branch
from
40070c4 to
c71bf37
Compare
artembilan
requested changes
Jul 15, 2025
* In the current implementation, users could pass in an empty list to the composite codec. * This is an CompositeCodec and if we had no codecs, then why have the class. * All @nullable's were removed from the delegate attribute. * Null returns from the findDelegate have been removed. The default delegate will be returned in the stead. * Update the tests to require at least one codec in the delegates
And also test if a user attempts to an invalid class.
Per code review. Thanks!
Change the `ClassUtils.findClosestMatch` `failOnTie` to true. In the past when finding the appropriate delegate(codec) for a object and their were multiple delegates available the first one was returned. The problem is it could return a different delegate on each launch of the `findDelegate`. Now with `failOnTie` set to true a `IllegalStateException` is returned. Remove deprecated constructor from CompositeCodec
…maintenance Rename field names of foo and foo2 in CompositeCodecTests to professional descriptive names In the onlyDefaultCodec implementation in the CompositeCodecTests use a class other than a PojoCodec class to simulate a real world case. Enhance javadoc for CompositeCodec to include information on ClassUtils.findClosestMatch and its effects on codec selection. Make sure @see is in the correct location in javadoc
Provide example for using CompositeCodec. Remove @see in CompositeCodec javadocs. This is handled in the links in the javadoc
Add code snippet to references to classes Verify no tabs exist in sample
cppwfs
force-pushed
the
SI-CLEANUP-COMPOSITE_CODEC
branch
from
c71bf37 to
bd73cd5
Compare
artembilan
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
LGTM.
But would be great to have #10207 reviewed and merged.
So, we could rebase this one before merge to working upstream.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nullable'swere removed from the delegate attribute.