Skip to content

Conversation

@cppwfs
Copy link
Contributor

@cppwfs cppwfs commented Nov 19, 2025

The Groovy DSL was missing support for the nullChannel, which is a special channel that discards messages (acts like /dev/null). This prevents users from using nullChannel in their Groovy integration flows.

Add unit tests to verify:

  • nullChannel can be used at the end of a flow
  • nullChannel can be used after transform operations
  • Messages are properly discarded without exceptions

The Groovy DSL was missing support for the nullChannel, which is a
special channel that discards messages (acts like /dev/null). This
prevents users from using nullChannel in their Groovy integration
flows.

Add unit tests to verify:
- nullChannel can be used at the end of a flow
- nullChannel can be used after transform operations
- Messages are properly discarded without exceptions
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

The original implementation had left the beans as dead code after initial tests were deemed to weak.
However, the dynamic flow increased the amount of code to maintain.

Changes include:
- Replace dynamic flow creation with `@Bean` configuration methods
- Add shared `nullCheckWireTapChannel` bean for message verification
- Simplify test methods by using autowired channels
- Add `@since 7.0.1` annotation to `nullChannel()` method documentation
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On last nit-pick

NullChannel for groovy DSL `see` and `since` annotation were moved to correct location
@artembilan artembilan merged commit 16e03b8 into spring-projects:main Nov 20, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants