Fix listener TaskExecutor config #1104
Open
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the factory task executor when creating new listener containers. Signed-off-by: Daniel Szabo <[email protected]>
garfailed
commented
May 1, 2025
| @@ -80,6 +81,7 @@ protected ConcurrentPulsarMessageListenerContainer<T> createContainerInstance(Pu | |||
| var containerProps = new PulsarContainerProperties(); | |||
|
|
|||
| // Map factory props (defaults) to the container props | |||
| containerProps.setConsumerTaskExecutor(factoryProps.getConsumerTaskExecutor()); | |||
There was a problem hiding this comment.
I didn't do the null check mentioned in the issue comment because this will always be a new instance. Most other options also assume we just want to set the factory values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1103
I noticed there are missing unit tests for the listener container default property setup. I tried creating them, but it seems like a larger piece of work with all the factory / endpoint / default branches.
Should I work on that and create a separate PR for it, or would it not add that much value?