Skip to content

Conversation

mheath
Copy link
Contributor

@mheath mheath commented Jul 2, 2025

Implements a simple mechanism for providing custom expression template values from enums used in expression templates.

Closes gh-17447

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 2, 2025
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mheath, for the PR! It's nice to hear from you again. I've left some feedback inline.

@jzheaux jzheaux self-assigned this Jul 23, 2025
@jzheaux jzheaux added the type: enhancement A general enhancement label Jul 23, 2025
@jzheaux jzheaux added this to the 7.0.x milestone Jul 23, 2025
@jzheaux jzheaux added in: core An issue in spring-security-core status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 23, 2025
@mheath
Copy link
Contributor Author

mheath commented Jul 31, 2025

Hey Josh. Thanks for taking a look at my PR. It's been too long. We need to catch up sometime in more than just PR comments!

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jul 31, 2025
@jzheaux jzheaux force-pushed the mheath/expression_template_value_provider branch from 89988e4 to ca58ca9 Compare July 31, 2025 17:09
@jzheaux
Copy link
Contributor

jzheaux commented Jul 31, 2025

Thanks for the updates, @mheath. Are you able to sign your commit?

(Note that I rebased, squashed, and added a polish commit before I noticed. Apologies, you may need to reset in order to push a change to your commit message.)

@mheath mheath force-pushed the mheath/expression_template_value_provider branch from ca58ca9 to cff5653 Compare August 1, 2025 16:47
@mheath
Copy link
Contributor Author

mheath commented Aug 1, 2025

Yep. My commit is signed.

@jzheaux
Copy link
Contributor

jzheaux commented Aug 4, 2025

This is what the CI sees:

Commit sha: 0b963d3, Author: Mike Heath, Committer: Mike Heath; The sign-off is missing.

image

In addition to the title and the reference to the ticket number, the commit message should say something like:

Signed-off-by: ...

I'm not sure why the commit in the PR doesn't have that. I'm sure you are already familiar, but just for easy reference, here is where GitHub reviews the DCO process.

@mheath mheath force-pushed the mheath/expression_template_value_provider branch from cff5653 to 6c3ac8c Compare August 4, 2025 20:31
@mheath
Copy link
Contributor Author

mheath commented Aug 4, 2025

Oops. I forgot that --gpg-sign doesn't add the DCO line. It's there now.

@jzheaux jzheaux modified the milestones: 7.0.x, 7.0.0-M2 Aug 5, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Aug 5, 2025

Excellent, @mheath. This will merge once the build completes. Thanks again!

@jzheaux jzheaux enabled auto-merge (rebase) August 5, 2025 15:04
@jzheaux jzheaux merged commit 6f1232c into spring-projects:main Aug 5, 2025
6 checks passed
@mheath mheath deleted the mheath/expression_template_value_provider branch August 7, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core status: feedback-provided Feedback has been provided type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom conversation for enum values in meta annotation expression templates
3 participants