Add XML configuration guidance to deprecation warnings #17753
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using XML-based Spring Security configuration, the standard <intercept-url> elements internally translate to the deprecated authorizeRequests mechanism, causing warnings that cannot be resolved by XML users. This change adds clarification to the deprecation warnings, informing XML users that: 1. The warning can be ignored for XML configurations 2. They should continue using standard <intercept-url> elements 3. The deprecation only affects Java/Kotlin configuration users This resolves the confusion for XML users who receive deprecation warnings despite using officially supported XML configuration. Closes spring-projectsgh-17259 Signed-off-by: khj68 <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds XML configuration guidance to the deprecation warnings in
DefaultFilterChainValidator.Problem
After upgrading to Spring Security 6.5.0, XML-configured applications receive deprecation warnings about
authorizeRequestsusage, even though they're using the officially supported XML<intercept-url>configuration. This creates confusion as XML users have no way to resolve these warnings.Solution
Added clarifying notes to the deprecation warning messages that:
<intercept-url>elementsChanges
DefaultFilterChainValidator.javato include XML-specific guidanceTesting
Closes gh-17259