add new parameter failOnError, which can be set to fail builds

[timbuethe]

This adds a new parameter called failOnError which should makes builds fail, instead of just logging an error, if the file download fails (return code != 200).

[timbuethe]

Hi,
is there any chance this gets reviewed and hopefully merged?
Is there anything else you need from my side to move forward?

cc: @DennisHalmstad @bnasslahsen

[amitojduggal]

@bnasslahsen possible to review this MR? Its a very useful feature to have.

[bnasslahsen]

@timbuethe,

I will have a look in the week-end!

[MrSebastian]

Hi @timbuethe,

i am also interested in your solution for #59. Can u add your handler at the catch-Block of exceptions too? It will help in situations like connection refused.

[MrSebastian]

I noticed that my application, that i started in pre-integration-test phase, did not stopped after the exception. I suggest to check, that the output exists, in the verify phase.

[timbuethe]

@MrSebastian I also added it to the catch clause, let men know what you think.

[MrSebastian]

@timbuethe thx, yes that would work and throw an exception when requested service is unreachable.

But as mentioned in my comment before, it would be useful to have a separate verify goal. But i guess this is something the maintainer should decide. I hope it is ok to discuss things like that in this PR (this is my first foreign github project I participate with).

[timbuethe]

@MrSebastian I agree, but let's see what @bnasslahsen has to say.

[S2Philipp]

It would also be nice to know why it failed to generate the file.
The 401 does not tell me anything actionable.

[ttddyy]

We are automating the spec file generation, and stopping on failure reduces our boilerplate scripts to handle failures.
It would be greatly appreciated if this feature gets merged and released.