Skip to content

feat: lifi compact message handler #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat: lifi compact message handler #61

wants to merge 17 commits into from

Conversation

mpetrun5
Copy link
Collaborator

Description

Related Issue Or Context

Closes: #51

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions GitHub Actions
Copy link

Go Test coverage is 55.7 %\ ✨ ✨ ✨

mpetrunic
mpetrunic reviewed Jul 29, 2025
View reviewed changes
Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we in lifi solver import validation from here?

protocol/mayan/api.go
url := fmt.Sprintf("%s/v3/swap/order-id/SWIFT_%s", MAYAN_EXPLORER_URL, hash)
url := fmt.Sprintf("%s/v3/swap/order-id/%s", MAYAN_EXPLORER_URL, hash)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this PR is the right place for this change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mistake 😨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic left review comments

@tcar121293 tcar121293 Awaiting requested review from tcar121293 tcar121293 is a code owner

@MakMuftic MakMuftic Awaiting requested review from MakMuftic MakMuftic is a code owner

@nmlinaric nmlinaric Awaiting requested review from nmlinaric nmlinaric is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LiFI Compact message handler
2 participants
@mpetrun5 @mpetrunic