This repository was archived by the owner on Mar 11, 2025. It is now read-only.
feat(evm): Expanding SDK to support Native transfer with optional con… #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k/native-transfer-contract-call
- added native token handler changes
saadahmsiddiqui
requested review from
Lykhoyda and
wainola
and removed request for
Lykhoyda
wainola
suggested changes
Sep 25, 2024
|
Tested by QA on testnet - works as expected |
wainola
previously approved these changes
Sep 25, 2024
saadahmsiddiqui
dismissed stale reviews from wainola and LyonSsS
via
acb1ac4
LyonSsS
approved these changes
Sep 26, 2024
This was referenced Sep 26, 2024
saadahmsiddiqui
pushed a commit
that referenced
this pull request
Sep 26, 2024
🤖 I have created a release *beep* *boop* --- ## [1.3.0](core-v1.2.3...core-v1.3.0) (2024-09-26) ### Features * **evm:** Expanding SDK to support Native transfer with optional con… ([#545](#545)) ([eb57424](eb57424)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
saadahmsiddiqui
pushed a commit
that referenced
this pull request
Sep 26, 2024
🤖 I have created a release *beep* *boop* --- ## [1.4.0](evm-v1.3.3...evm-v1.4.0) (2024-09-26) ### Features * **evm:** Expanding SDK to support Native transfer with optional con… ([#545](#545)) ([eb57424](eb57424)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation details
With PR#266, we introduced the ability to define contract calls together with native deposit. As SDK didn't integrate the initial implementation of native handlers, it needs to be expanded so it can be used to create:
Deposit of native currency (tokens)
Deposit of native currency (tokens) + contract call definition
The Native flow differs slightly from regular ERC20/721/1155, as the deposit transaction should not land on Bridge.sol but on NativeAdapter.sol contract. We have already expanded the testnet shared configuration to have this as a new property of the domain - nativeTokenAdapter.
Closes: #521
Testing details
Unit Tests: Develop unit tests that cover scenarios where both Native transfers and contract calls are involved.
Error Handling: Test how the SDK handles invalid or failed contract calls within the transaction flow.
Acceptance Criteria