Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GMP native token handler adapter #253

Closed
wants to merge 4 commits into from

Conversation

nmlinaric
Copy link
Contributor

Description

Adds adapter for native token trasnfers via GMP.

Related Issue Or Context

Closes: #231

How Has This Been Tested? Testing details.

unit and e2e tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

Copy link
Contributor

@lastperson lastperson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If native currencies are of the same value between the origin and destination, then perhaps we should have a single adapter implementation deployed on both chains to facilitate movement in both directions?

@nmlinaric nmlinaric requested a review from lastperson June 24, 2024 12:40
@nmlinaric nmlinaric changed the title feat: add native token handler adapter feat: add GMP native token handler adapter Jul 3, 2024
@nmlinaric nmlinaric requested a review from lastperson July 8, 2024 13:32
Copy link
Collaborator

@mpetrun5 mpetrun5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is OK, though I would consider adapter implementations be part of another repo with them.
sygma-solidity IMO should only be for core solidity stuff.

@nmlinaric
Copy link
Contributor Author

Closing this as for the time being it will not be used in production

@nmlinaric nmlinaric closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapter for native currency transfers
3 participants