chore: address Veridise findings #272

lastperson · 2024-09-09T20:09:52Z

Description

All details will be added when internal discussions finalize.

All the changes so far are covered by the exiting tests.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation

I have commented my code, particularly in hard-to-understand areas.
I have ensured that all acceptance criteria (or expected behavior) from issue are met
I have updated the documentation locally and in chainbridge-docs.
I have added tests to cover my changes.
I have ensured that all the checks are passing and green, I've signed the CLA bot

lastperson added 5 commits September 10, 2024 03:04

Address findings 2, 3, 4, 8

a94faf9

Address finding 7

9114518

Address finding 5

f971a2b

Redo fix for finding 3

15a1c1c

Fix tests for finding 7

7921f5e

lastperson requested review from MakMuftic, mpetrun5 and nmlinaric September 10, 2024 11:15

mpetrun5 approved these changes Sep 10, 2024

View reviewed changes

nmlinaric approved these changes Sep 10, 2024

View reviewed changes

lastperson added 4 commits September 10, 2024 22:01

Update deposit() comments

a2c7812

Add helper and explanation for 6

37d6af8

Stabilize forked tests

b3b5afb

Fix typos

78ff811

lastperson marked this pull request as ready for review September 12, 2024 16:04

lastperson merged commit 2cc1c20 into feat/erc20ContractCall Sep 12, 2024
5 checks passed