Rework system tables #548
Merged
Rework system tables #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfhbd
force-pushed
the
hfhbd/reworkSystemTables
branch
from
5ed312d
to
baaa137
Compare
hfhbd
force-pushed
the
hfhbd/reworkSystemTables
branch
from
baaa137
to
0451752
Compare
hfhbd
force-pushed
the
hfhbd/reworkSystemTables
branch
from
0451752
to
71eef38
Compare
AlecKazakova
approved these changes
Oct 18, 2023
|
I will update this PR to reflect the lazy psi file creating. I am fine with both merge strategies, either sqldelight or sql-psi first, but keep in mind the tests in sqldelight will fail until there is a new sql-psi release. |
AlecKazakova
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dislike the (my) current implementation of system tables. We should use the
baseContributorFilesmethod instead.