Skip to content

Conversation

@Gioee
Copy link
Member

@Gioee Gioee commented Feb 7, 2025

Description of change

I've moved to peerDependencies react native related dependencies, this way they are installed with npm install but they can be skipped in non react native environments, where they're useless.

I've also added a clean.test.ts file with a script that cleans the workflow project by old test databases.

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

@Gioee Gioee added the enhancement New feature or request label Feb 7, 2025
@Gioee Gioee requested a review from danielebriggi February 7, 2025 19:35
@Gioee Gioee self-assigned this Feb 7, 2025
Copy link
Member

@danielebriggi danielebriggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A consideration

@Gioee Gioee changed the title Move react native dependencies to peer move react native dependencies to peer and fix test to auto remove testing dbs Feb 10, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.26%. Comparing base (3d99265) to head (6ca5657).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   87.26%   87.26%           
=======================================
  Files          11       11           
  Lines         974      974           
  Branches      286      286           
=======================================
  Hits          850      850           
  Misses        124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gioee Gioee changed the title move react native dependencies to peer and fix test to auto remove testing dbs feat(react-native): move rn deps to peerdeps, fix(test): auto remove test dbs Feb 10, 2025
@Gioee Gioee merged commit e3638c8 into main Feb 10, 2025
24 checks passed
@Gioee Gioee deleted the move-react-native-dependencies-to-peer branch February 10, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants