SPM support #213 #339
Merged
SPM support #213 #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lickel
force-pushed
the
spm
branch
2 times, most recently
from
10d91e7 to
84adbcc
Compare
|
@kyleve updated |
kyleve
reviewed
Oct 25, 2021
|
@kyleve enabled test targets |
lickel
commented
Oct 25, 2021
| dependencies: ["ListableUI", "EnglishDictionary", "Snapshot"], | ||
| path: "ListableUI/Tests", | ||
| exclude: [ | ||
| "Layout/Paged/Snapshot Results", |
There was a problem hiding this comment.
I need to exclude all the snapshots for two reasons:
- The folder-reusing-filename confuses the compiler
- SPM wouldn't know how to deal with .test files anyways
kyleve
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will not do the magic +load registration, but otherwise should be fine.
#213