Add Serialization for protobuf enum values #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another Serialization impl, for the actual enum values (not the enum value descriptors, like ProtobufEnumSerialization).
I used reflection to get at the enum classes "valueOf". Since I only get the method once, I hope it does not add terrible overhead.
By the way, ProtobufEnumSerialization seems incomplete — deserialize returns null. Do we also want serialization for the enum value descriptors? I guess the motivation was that getField for an enum field returns a value descriptor instead of the actual value?