fix: catch any HTTP errors at exchange.generate(...)
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifeizhou-ap
reviewed
Sep 3, 2024
| tools=self.tools, | ||
| ) | ||
| num_times_attempted = 0 | ||
| while num_times_attempted < 3: |
There was a problem hiding this comment.
current retry in the provider is 5. does this mean we will retry 15 times with worst scenarios?
Do we need num_times_attempted: 3 or just 1 here?
There was a problem hiding this comment.
Yea, so here we are retrying after modifying the messages array. We try popping off as little context as possible, and can try doing that up to 3 times. I am not hard-set on the 3 times, but figured it would at least land us in a spot for subsequent discussion with the team.
michaelneale
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.