Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for configuration cache bug #2890

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

staktrace
Copy link
Collaborator

This is a test for the scenario in #2837 which has since been fixed already.

This is a test for the scenario in square#2837
which has since been fixed already.
org.gradle.caching=false
org.gradle.unsafe.configuration-cache=true
org.gradle.configuration-cache=true
VERSION_NAME=5.0.0-SNAPSHOT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omit this one? I don’t wanna have to keep it up-to-date

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's required by the runner:

fail("Fixture's gradle.properties has to include the VERSION_NAME entry.")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have it somewhere else as well I think, our releasing steps update it so should be good

@staktrace staktrace merged commit f7ad0e8 into square:master Apr 4, 2024
11 checks passed
@oldergod
Copy link
Member

oldergod commented Apr 4, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants