Skip to content

Use System.Security.Cryptography in AesCipher #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Use System.Security.Cryptography in AesCipher #1235

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93e4c76
Use System.Security.Cryptography in AesCipher
Rob-Hague Nov 4, 2023
9e4cc85
don't set the IV - it is unused by ECB
Rob-Hague Nov 12, 2023
382ec6f
Merge branch 'develop' into aesssc
WojciechNagorski Nov 13, 2023
74b3ca3
Dispose ciphers in Session if applicable
Rob-Hague Nov 13, 2023
8b4159b
Merge branch 'develop' into aesssc
WojciechNagorski Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Renci.SshNet/PrivateKeyFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,14 @@ private static Key ParseOpenSshV1Key(byte[] keyFileData, string passPhrase)
throw new SshException("Cipher '" + cipherName + "' is not supported for an OpenSSH key.");
}

privateKeyBytes = cipher.Decrypt(privateKeyBytes);
try
{
privateKeyBytes = cipher.Decrypt(privateKeyBytes);
}
finally
{
cipher.Dispose();
}
}

// validate private key length
Expand Down
Loading