Skip to content

Conversation

@lutzleonhardt
Copy link

@lutzleonhardt lutzleonhardt commented Aug 11, 2025

Align the package export map with the actual build output for the contexts module.
The source is src/lib/contexts.svelte.ts, which emits contexts.svelte.js and contexts.svelte.d.ts. Exports incorrectly pointed to contexts.js/contexts.d.ts.

Changes

  • package.json
    • Exports: "./contexts" → point to ./dist/contexts.svelte.js and ./dist/contexts.svelte.d.ts
    • typesVersions: "contexts" → ./dist/contexts.svelte.d.ts
    • Version bump: 5.0.3 (patch)

Why

  • Downstream builds failed to resolve svelte-exmarkdown/contexts in clean installs.

Impact

  • Backward compatible.
  • Consumers can import svelte-exmarkdown/contexts reliably.

Verification

  • Run svelte-package and inspect dist: contexts.svelte.{js,d.ts} exist.
  • From a clean project, import svelte-exmarkdown/contexts and confirm both runtime and types resolve.

Summary by CodeRabbit

  • Bug Fixes

    • Improved Svelte compatibility by correcting module resolution for the contexts package.
    • Fixed TypeScript typings resolution for editors and build tools targeting Svelte.
  • Chores

    • Bumped version to 5.0.3.

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2025

⚠️ No Changeset found

Latest commit: 2ddf9a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Aug 11, 2025

Walkthrough

Version bumped to 5.0.3. The exports map for ./contexts now points to Svelte-specific build artifacts (contexts.svelte.js/.d.ts). The typesVersions mapping for >4.0 was updated to reference contexts.svelte.d.ts.

Changes

Cohort / File(s) Change summary
Package metadata and exports
package.json
Version 5.0.2 → 5.0.3; exports["./contexts"] now uses ./dist/contexts.svelte.js and ./dist/contexts.svelte.d.ts; typesVersions[">4.0"].contexts updated to ./dist/contexts.svelte.d.ts.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I twitch my whiskers, hop with cheer,
A tiny bump from there to here.
New Svelte-y paths, neatly aligned,
Types in tow, all well-defined.
Thump-thump! The version’s up a notch—
A tidy warren, ship it, watch! 🥕🐇

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
package.json (1)

105-106: Correct export targets for ./contexts — LGTM.

Pointing to contexts.svelte.{d.ts,js} aligns exports with build output and unblocks consumers.

Optional: For consistency with other subpath exports and to help bundlers prefer the Svelte condition, consider adding the "svelte" condition too.

 {
   "exports": {
     "./contexts": {
       "types": "./dist/contexts.svelte.d.ts",
-      "default": "./dist/contexts.svelte.js"
+      "svelte": "./dist/contexts.svelte.js",
+      "default": "./dist/contexts.svelte.js"
     }
   }
 }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed7a024 and 2ddf9a6.

📒 Files selected for processing (1)
  • package.json (3 hunks)
🔇 Additional comments (2)
package.json (2)

4-4: Confirm release workflow (Changesets vs manual bump).

You bumped version to 5.0.3. If the repo’s release flow is driven by Changesets, consider adding a changeset and letting automation handle the bump to keep CHANGELOG in sync. Otherwise, manual bump is fine but be aware pnpm changeset publish won’t produce a new changelog entry without a changeset.

Would you like me to generate a changeset entry for this fix?


140-140: TypesVersions mapping confirmed—LGTM

The "contexts" subpath now correctly points to ./dist/contexts.svelte.d.ts, and our scan shows no remaining contexts.d.ts or contexts.js references in package.json. All other exports still resolve to the dist directory as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant