-
Notifications
You must be signed in to change notification settings - Fork 12
fix: correct ./contexts export map to contexts.svelte.* and bump to 5.0.3 #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: correct ./contexts export map to contexts.svelte.* and bump to 5.0.3 #351
Conversation
|
WalkthroughVersion bumped to 5.0.3. The exports map for ./contexts now points to Svelte-specific build artifacts (contexts.svelte.js/.d.ts). The typesVersions mapping for >4.0 was updated to reference contexts.svelte.d.ts. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
105-106: Correct export targets for ./contexts — LGTM.Pointing to contexts.svelte.{d.ts,js} aligns exports with build output and unblocks consumers.
Optional: For consistency with other subpath exports and to help bundlers prefer the Svelte condition, consider adding the "svelte" condition too.
{ "exports": { "./contexts": { "types": "./dist/contexts.svelte.d.ts", - "default": "./dist/contexts.svelte.js" + "svelte": "./dist/contexts.svelte.js", + "default": "./dist/contexts.svelte.js" } } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
package.json(3 hunks)
🔇 Additional comments (2)
package.json (2)
4-4: Confirm release workflow (Changesets vs manual bump).You bumped version to 5.0.3. If the repo’s release flow is driven by Changesets, consider adding a changeset and letting automation handle the bump to keep CHANGELOG in sync. Otherwise, manual bump is fine but be aware
pnpm changeset publishwon’t produce a new changelog entry without a changeset.Would you like me to generate a changeset entry for this fix?
140-140: TypesVersions mapping confirmed—LGTMThe
"contexts"subpath now correctly points to./dist/contexts.svelte.d.ts, and our scan shows no remainingcontexts.d.tsorcontexts.jsreferences in package.json. All other exports still resolve to thedistdirectory as expected.
Align the package export map with the actual build output for the contexts module.
The source is
src/lib/contexts.svelte.ts, which emitscontexts.svelte.jsand contexts.svelte.d.ts. Exports incorrectly pointed tocontexts.js/contexts.d.ts.Changes
Why
Impact
Verification
Summary by CodeRabbit
Bug Fixes
Chores