Skip to content

fix: handle uppercase image extensions when pasting file paths #6005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nem035 wants to merge 1 commit into
base: dev
Choose a base branch
from
+22 −3
Open

fix: handle uppercase image extensions when pasting file paths #6005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions packages/opencode/src/cli/cmd/tui/component/prompt/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,22 @@ export type PromptRef = {

const PLACEHOLDERS = ["Fix a TODO in the codebase", "What is the tech stack of this project?", "Fix broken tests"]

// Bun.file() only recognizes lowercase extensions, so uppercase extensions like .PNG, .JPG
// return "application/octet-stream". This function returns the correct MIME type.
const IMAGE_EXTENSIONS: Record<string, string> = {
".png": "image/png",
".jpg": "image/jpeg",
".jpeg": "image/jpeg",
".gif": "image/gif",
".webp": "image/webp",
".svg": "image/svg+xml",
}

function getImageMime(filepath: string): string | undefined {
const ext = filepath.slice(filepath.lastIndexOf(".")).toLowerCase()
return IMAGE_EXTENSIONS[ext]
}

const TEXTAREA_ACTIONS = [
"submit",
"newline",
Expand Down Expand Up @@ -836,16 +852,19 @@ export function Prompt(props: PromptProps) {
if (!isUrl) {
try {
const file = Bun.file(filepath)
// Bun.file() only recognizes lowercase extensions, so use our helper
// to get the correct MIME type for uppercase extensions like .PNG, .JPG
const mime = getImageMime(filepath) ?? file.type
// Handle SVG as raw text content, not as base64 image
if (file.type === "image/svg+xml") {
if (mime === "image/svg+xml") {
event.preventDefault()
const content = await file.text().catch(() => {})
if (content) {
pasteText(content, `[SVG: ${file.name ?? "image"}]`)
return
}
}
if (file.type.startsWith("image/")) {
if (mime.startsWith("image/")) {
event.preventDefault()
const content = await file
.arrayBuffer()
Expand All @@ -854,7 +873,7 @@ export function Prompt(props: PromptProps) {
if (content) {
await pasteImage({
filename: file.name,
mime: file.type,
mime,
content,
})
return
Expand Down