-
Notifications
You must be signed in to change notification settings - Fork 250
feat(diff): add word-level highlighting for modified lines #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
remorses
wants to merge
28
commits into
sst:main
Choose a base branch
from
remorses:word-highlights
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+696
−188
Open
Changes from 12 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
ec432ca
add word highlights
remorses c0ceee1
test: add word highlight tests
remorses 85e2afd
format
remorses 45884fe
fix: use Bun.stringWidth for multi-width character support in word hi…
remorses ebfc48c
fix: correct line counts in example diff hunk header
remorses a5a9136
update react example
remorses d663823
rename showWordHighlights to disableWordHighlights
remorses 117e470
chore: remove verbose comments
remorses 1c2e986
refactor: simplify word highlights code
remorses 6cc3958
fix: revert unrelated simplifications to split view forEach loops
remorses 4a96d11
Merge upstream/main into word-highlights
remorses 88080c0
chore: format Diff.ts
remorses 912849e
fix: word highlights scroll with content when scrollX is non-zero
remorses f437756
fix: word highlights respect line wrapping
remorses 8989ff0
fix: correctly compute column offset for wrapped line highlights
remorses 8e63649
cleanup: remove excessive comments
remorses cbc18de
test: use inline snapshots with trimmed lines for scrollX tests
remorses 212bec3
test: remove obsolete external snapshots
remorses d3175de
test: remove useless word highlight tests that don't test anything me…
remorses 9a100ea
test: remove scrollX tests that can't verify highlight rendering
remorses 570e067
chore: format
remorses 4da4af0
Merge branch 'main' into word-highlights
remorses 0b2ef8b
use diff with words for similarity
remorses b00521e
Merge branch 'word-highlights' of https://github.com/remorses/opentui…
remorses 802361d
increase default lineSimilarityThreshold to 0.5
remorses e74a3fa
fix test: update expected default lineSimilarityThreshold to 0.5
remorses c650652
Merge branch 'main' into word-highlights
remorses a8ceb5e
derive word highlight colors from hunk colors with brighten + opacity…
remorses File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.