fix: hide terminal cursor when showCursor is false #441
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remorses
force-pushed
the
fix-show-cursor-visibility
branch
from
23b38e5 to
13167e7
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the terminal cursor remained visible when the showCursor property was changed from true to false on a focused component. The issue occurred because the renderCursor method would simply return early without actively hiding the cursor that was already displayed.
Key changes:
- Added immediate cursor hiding when
showCursortransitions tofalsewhile the component is focused
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
showCursorprop changes fromtruetofalse, the cursor was still visible becauserenderCursorjust returned early without hiding the cursor.This fix calls
setCursorPosition(0, 0, false)to hide the terminal cursor whenshowCursoris false or the component is not focused.