Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add demo upgrade issue template #120

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Nov 11, 2024

This moves the template from the issues repo to here.

Note

Requires a change in the issue templates located in the issues repo.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of things to add.

jupyterhub https://jupyterhub.github.io/helm-chart/
opensearch https://opensearch-project.github.io/helm-charts
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of handy things to add:

Suggested change
To add any that are missing, run:
```shell
helm repo add bitnami https://charts.bitnami.com/bitnami --force-update
```
Then make sure you have the latest indexes:
```shell
helm repo update
```

Comment on lines +56 to +57
Use the latest version displayed to replace the current one in the YAML files. Take a look at
previous PRs for additional guidance, eg. <https://github.com/stackabletech/demos/pull/119>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some cases we can't use the latest (eg: Vector, where the app version is selected during product version planning).

Suggested change
Use the latest version displayed to replace the current one in the YAML files. Take a look at
previous PRs for additional guidance, eg. <https://github.com/stackabletech/demos/pull/119>.
Use the applicable chart version displayed to replace the current one in the YAML files. Make sure
to add the app version in the comments. Eg:
```yml
version: 3.2.1 # 1.2.3
```
Take a look at previous PRs for additional guidance, eg. <https://github.com/stackabletech/demos/pull/119>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants