Fix technical debts #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siegfriedweber
commented
Aug 29, 2025
| @@ -185,7 +185,6 @@ impl IsLabelValue for ValidatedCluster { | |||
| } | |||
| } | |||
|
|
|||
| // TODO Remove boilerplate (like derive_more) | |||
There was a problem hiding this comment.
It is better to leave it as is instead of adding another crate just for this one case.
siegfriedweber
commented
Aug 29, 2025
| }; | ||
|
|
||
| pub const CONFIGURATION_FILE_OPENSEARCH_YML: &str = "opensearch.yml"; | ||
|
|
||
| // TODO Document how to enter config_overrides of various types, e.g. string, list, boolean, |
siegfriedweber
commented
Aug 29, 2025
| @@ -49,8 +49,6 @@ impl<'a> RoleBuilder<'a> { | |||
| } | |||
| } | |||
|
|
|||
| // TODO Only one builder function which calls the other ones? | |||
There was a problem hiding this comment.
It is okay as it is.
siegfriedweber
commented
Aug 29, 2025
| DISABLE_INSTALL_DEMO_CONFIG: "true" | ||
| OPENSEARCH_HOME: {{ test_scenario['values']['opensearch_home'] }} | ||
| configOverrides: | ||
| # TODO Add the required options to the operator |
There was a problem hiding this comment.
There are follow-up tickets. No need for these TODOs in the code.
siegfriedweber
commented
Aug 29, 2025
| opensearch.yml: | ||
| # Disable memory mapping in this test; If memory mapping were activated, the kernel setting | ||
| # vm.max_map_count would have to be increased to 262144 on the node. | ||
| node.store.allow_mmap: "false" | ||
| # TODO Check that this is safe despite the warning in the documentation |
There was a problem hiding this comment.
It is safe if the demo configuration is replaced with podOverrides. To be on the safe side, I removed the demo configuration in stackabletech/docker-images#1228.
siegfriedweber
commented
Aug 29, 2025
| @@ -1,7 +1,6 @@ | |||
| # All fields are checked that are set by the operator. | |||
| # This helps to detect unintentional changes. | |||
| # The maintenance effort should be okay as long as it is only done in the smoke test. | |||
| # TODO Check individual field in unit tests | |||
There was a problem hiding this comment.
There is a follow-up task in #2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The remaining TODOs are fixed or removed if not necessary anymore.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker