Skip to content

add new method getStaticPages #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add new method getStaticPages #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,12 +378,15 @@ class SourcebitDataClient {
return fse.readJson(DEFAULT_FILE_CACHE_PATH);
}

async getStaticPages() {
const data = await this.getData();
let paths = _.map(data.pages, (page) => page);
return paths;
}
Comment on lines +381 to +385
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JugglerX isn't the path variable should be pages?
And also, why not:

    async getStaticPages() {
      const data = await this.getData();
      return data.pages;
  }

And if are already there, do we really need this low resolution helper methods?
Wouldn't calling sourcebitDataClient.getData().pages be enough?


async getStaticPaths() {
const data = await this.getData();
let paths = _.map(data.pages, (page) => page.path);
if (process.env.NODE_ENV === 'development') {
paths = paths.concat(_.map(paths, (pagePath) => pagePath + (pagePath !== '/' ? '/' : '')));
}
Comment on lines -384 to -386
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JugglerX any reason you removed this.
Originally I've added this because we had a bug:

bug: https://www.notion.so/stackbit/Studio-When-navigating-to-a-page-it-loads-twice-76d463bb0ded413c8da7767172af8470#08fc4d6ad4804b3e8a8c32f1e8a33baa

commit: e77a66d

return paths;
}

Expand Down
Loading