Skip to content

fix(react): allow preview panel to be fully collapsed #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025

Conversation

isaacplmann
Copy link
Contributor

My tutorial does not heavily use the preview panel, but always uses the terminal. This change allows the terminal to be open and the preview panel to be collapsed all the way (by the user). The initial size of the preview panel stays the same.

Copy link

stackblitz bot commented Apr 11, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@isaacplmann
Copy link
Contributor Author

Seems like the multiple preview window e2e test is flaky. Even locally it will pass and not pass on subsequent runs without changing the code.

@AriPerkkio
Copy link
Member

@isaacplmann could you show screenshots of before-after this change?

I haven't seen that test case being flaky before. Could it be that it becomes flaky with this change when window is smalle enough?

@isaacplmann
Copy link
Contributor Author

When you click Toggle Terminal this is what the preview panel looks like both before and after the change.
Screenshot 2025-04-14 at 8 41 15 AM

Before the change, this is the smallest you can make the preview panel:
Screenshot 2025-04-14 at 8 41 37 AM

After the change, you can completely hide the preview panel with the terminal:
Screenshot 2025-04-14 at 8 40 03 AM

Here's an image of the e2e test passing locally:
Screenshot 2025-04-14 at 8 38 34 AM

@isaacplmann
Copy link
Contributor Author

isaacplmann commented Apr 14, 2025

Here's a screenshot of the user can see multiple preview tabs e2e test failing on main. I had to run the e2e tests 5 times before the test failed.
Screenshot 2025-04-14 at 9 07 50 AM

Copy link

pkg-pr-new bot commented Apr 15, 2025

Open in StackBlitz

@tutorialkit/astro

npm i https://pkg.pr.new/@tutorialkit/astro@445

@tutorialkit/react

npm i https://pkg.pr.new/@tutorialkit/react@445

@tutorialkit/theme

npm i https://pkg.pr.new/@tutorialkit/theme@445

@tutorialkit/types

npm i https://pkg.pr.new/@tutorialkit/types@445

@tutorialkit/runtime

npm i https://pkg.pr.new/@tutorialkit/runtime@445

commit: a54374a

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 💯

@AriPerkkio AriPerkkio merged commit 11aa9ad into stackblitz:main Apr 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants