-
Notifications
You must be signed in to change notification settings - Fork 72
fix(react): allow preview panel to be fully collapsed #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): allow preview panel to be fully collapsed #445
Conversation
|
Seems like the multiple preview window e2e test is flaky. Even locally it will pass and not pass on subsequent runs without changing the code. |
@isaacplmann could you show screenshots of before-after this change? I haven't seen that test case being flaky before. Could it be that it becomes flaky with this change when window is smalle enough? |
@tutorialkit/astro
@tutorialkit/react
@tutorialkit/theme
@tutorialkit/types
@tutorialkit/runtime
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! 💯
My tutorial does not heavily use the preview panel, but always uses the terminal. This change allows the terminal to be open and the preview panel to be collapsed all the way (by the user). The initial size of the preview panel stays the same.