feat(core): Add autoStart feature #98
Conversation
| @@ -36,6 +36,8 @@ | |||
| }, | |||
| "dependencies": { | |||
| "fast-equals": "^5.0.1", | |||
| "object-hash": "^3.0.0", | |||
| "react-native-mmkv-storage": "^0.9.1", | |||
There was a problem hiding this comment.
Let's move this to devDependencies as it's an optional peer dependency 🙂
| @@ -73,6 +76,7 @@ | |||
| "peerDependencies": { | |||
| "react": ">=16.8.0", | |||
| "react-native": ">=0.50.0", | |||
| "react-native-mmkv-storage": ">=0.9.1", | |||
There was a problem hiding this comment.
We need to add this one to peerDependenciesMeta and mark it as optional: true
| const storage = new MMKVLoader().initialize(); | ||
|
|
||
| export default storage; |
There was a problem hiding this comment.
We should try to avoid default exports in favor of named exports 🙂
| const storage = new MMKVLoader().initialize(); | |
| export default storage; | |
| export const storage = new MMKVLoader().initialize(); |
| @@ -0,0 +1,5 @@ | |||
| import { MMKVLoader } from "react-native-mmkv-storage"; | |||
There was a problem hiding this comment.
This is an optional dependency, so it's possible that it's not present in some environments. Shouldn't the import fail in those cases? A way to solve that is by using dynamic imports.
import("react-native-mmkv-storage")
.then(({ MMKVLoader }) => {
// do something with the imported modules
})
.catch((error: unknown) => {
// handle whenever the module is not present
});| @@ -0,0 +1,5 @@ | |||
| import { MMKVLoader } from "react-native-mmkv-storage"; | |||
|
|
|||
| const storage = new MMKVLoader().initialize(); | |||
There was a problem hiding this comment.
Maybe we should initialize the store only when the autoStart option is set to always | once, otherwise it makes no sense to initialize something that is not going to be used 😉
| } = props; | ||
|
|
||
| const [current, setCurrent] = useState<number>(); | ||
| const [spot, setSpot] = useState(ZERO_SPOT); | ||
| const [tourId, setTourId] = useMMKVStorage("tourId", storage, ""); |
| renderStep(0); | ||
| onStart?.(); |
There was a problem hiding this comment.
I think these two can be replaced by calling the start() function
|
|
||
| const startOnce = useCallback(() => { | ||
| if (!tourId) { | ||
| setTourId(hash(steps)); |
There was a problem hiding this comment.
What happens if the user has multiple tour providers in their app. I think we will need them to provide an ID of the tour to use this feature, and the value we check against is the hash of the steps. What do you think? 🤔
| @@ -136,7 +138,18 @@ jest | |||
| timing: timingMock, | |||
| }, | |||
| }; | |||
| }); | |||
| }) | |||
| /* eslint-disable @typescript-eslint/no-unused-vars */ | |||
This PR address issue #50