Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multi auth error checking #2018

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Mar 24, 2025

Description

Based on #2010

Since we will remove this error checking code in #2007 anyway, I want to already remove it in this separate PR to get it out of the way of refactoring the client code for account switching for #2007.

Checklist

Are your changes backwards compatible? Please answer below:

yes

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:

8. This only removes future dead code. I searched for multiAuthError to make sure I didn't miss any reference to it.

For frontend changes: Tested on mobile, light and dark mode? Please answer below:

n/a

Did you introduce any new environment variables? If so, call them out explicitly here:

no

@ekzyis ekzyis force-pushed the remove-multi-auth-error-checking branch from afec573 to f999ad3 Compare March 24, 2025 22:52
@huumn huumn merged commit d7e01d0 into master Mar 25, 2025
6 checks passed
@huumn huumn deleted the remove-multi-auth-error-checking branch March 25, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants