Reset if pointer is not a number or JWT cannot be decoded #2021
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzyis
force-pushed
the
reset-on-pointer-NaN-or-jwt-decode-error
branch
from
059fd6f to
0b8f463
Compare
ekzyis
commented
Mar 25, 2025
| @@ -91,14 +91,24 @@ function switchSessionCookie (request) { | |||
| return request | |||
| } | |||
|
|
|||
| export function checkMultiAuthCookies (req, res) { | |||
| async function checkMultiAuthCookies (req, res) { | |||
There was a problem hiding this comment.
export wasn't needed and was accidentally added back in #1998
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This can handle more potential issues.
Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7. Cookies are reset if pointer is not a number or if we fail to decode the JWT.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no