Update NDK to v2.12.2 #2041
Merged
Update NDK to v2.12.2 #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Tested attaching NWC send. It broke:
|
ekzyis
force-pushed
the
fix-nip46
branch
2 times, most recently
from
cff79f2 to
6030b58
Compare
ekzyis
commented
Mar 30, 2025
| @@ -17,10 +17,12 @@ | |||
| "@apollo/server": "^4.11.0", | |||
| "@as-integrations/next": "^3.1.0", | |||
| "@auth/prisma-adapter": "^2.7.0", | |||
| "@cashu/cashu-ts": "^2.4.1", | |||
There was a problem hiding this comment.
This is unfortunately required even though it's supposed to be a peer dependency of ndk-wallet (which is itself a peer dependency).
If I don't install this, the app fails to start:
app | 2025-03-30T21:06:26.954347000Z ⨯ ./node_modules/@nostr-dev-kit/ndk-wallet/dist/index.mjs:344:1
app | 2025-03-30T21:06:26.954485000Z Module not found: Can't resolve '@cashu/cashu-ts'
app | 2025-03-30T21:06:26.954523000Z
app | 2025-03-30T21:06:26.954556000Z https://nextjs.org/docs/messages/module-not-found
app | 2025-03-30T21:06:26.954595000Z
app | 2025-03-30T21:06:26.954632000Z Import trace for requested module:
app | 2025-03-30T21:06:26.954660000Z ./wallets/nwc/index.js
app | 2025-03-30T21:06:26.954684000Z ./wallets/nwc/client.js
app | 2025-03-30T21:06:26.954706000Z ./wallets/client.js
app | 2025-03-30T21:06:26.954740000Z ./wallets/index.js
app | 2025-03-30T21:06:26.954769000Z ./components/pay-bounty.js
app | 2025-03-30T21:06:26.954795000Z ./components/comment.js
app | 2025-03-30T21:06:26.954822000Z ./components/items.js
app | 2025-03-30T21:06:26.954850000Z ./pages/~/index.js
app | 2025-03-30T21:06:26.982840000Z automatically enabled Fast Refresh for 1 custom loader
app | 2025-03-30T21:06:29.830712000Z ⨯ ./node_modules/@nostr-dev-kit/ndk-wallet/dist/index.mjs:344:1
app | 2025-03-30T21:06:29.830824000Z Module not found: Can't resolve '@cashu/cashu-ts'
app | 2025-03-30T21:06:29.830861000Z
app | 2025-03-30T21:06:29.830892000Z https://nextjs.org/docs/messages/module-not-found
app | 2025-03-30T21:06:29.830928000Z
app | 2025-03-30T21:06:29.830959000Z Import trace for requested module:
app | 2025-03-30T21:06:29.831002000Z ./wallets/nwc/index.js
app | 2025-03-30T21:06:29.831036000Z ./wallets/nwc/client.js
app | 2025-03-30T21:06:29.831068000Z ./wallets/client.js
app | 2025-03-30T21:06:29.831098000Z ./wallets/index.js
app | 2025-03-30T21:06:29.831141000Z ./pages/_app.js
|
Attached the diff of ndk v2.10.5 to v.2.12.2. The answer to why it broke should be in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #2038. The issue was not a timeout (there is no timeout for authentication) but we had to upgrade NDK.
Additional context
I don't know what changed in NDK to make it work. NDK has no documentation of releases, no changelog or working developer documentation. Maybe the spec changed, but I see no breaking change in its history.
Guess I have to run a diff myself. Will do so tomorrow. Converting to draft until we can be sure there is nothing sketchy going on.
TODO:
(do we have other nostr stuff?)
Video
2025-03-28.23-55-40.mp4
Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7. Tested withnak, see video. Also tested other nostr stuff, see checkboxes.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no