Skip to content

Change defaults so a cookiecutter environment is fully functional #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 8, 2025

Conversation

wtripp180901
Copy link
Contributor

@wtripp180901 wtripp180901 commented Nov 11, 2024

  • NB: Changes default selinux_state to disabled to allow prometheus to work
  • Enables etc_hosts by default to provide working internal name resolution
  • Adds working defaults for OpenOndemand (likely to need changing for production):
    • Use basic_auth + PAM for authentication
    • Use ansible_host (i.e. IP address) as the ondemand external "servername"
  • Creates a default user to access ondemand with
  • Default cluster suffix is now "internal" instead of "invalid" now the former is reserved by ICANN for private-use applications.
  • Grafana anonymous auth is now enabled by default for new environments

@sjpb
Copy link
Collaborator

sjpb commented Nov 22, 2024

@wtripp180901 when you get back to this pls can you update docs/production.md too?

@sjpb sjpb changed the title Defaults from common and cookiecutter now give working appliance Change defaults so a cookiecutter environment is fully functional Jan 2, 2025
@wtripp180901 wtripp180901 requested a review from sjpb January 2, 2025 15:16
@sjpb
Copy link
Collaborator

sjpb commented Jan 3, 2025

See also #432

Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks, mostly to make it consistent with the other docs

@wtripp180901 wtripp180901 force-pushed the feat/skeleton-defaults branch 2 times, most recently from 55606e7 to 1988d9a Compare January 6, 2025 09:54
@wtripp180901 wtripp180901 changed the base branch from feature/k3s-monitoring to main January 6, 2025 10:06
@wtripp180901 wtripp180901 changed the base branch from main to feature/k3s-monitoring January 6, 2025 10:07
@wtripp180901 wtripp180901 force-pushed the feat/skeleton-defaults branch from 1988d9a to 1f3298d Compare January 6, 2025 10:18
@wtripp180901 wtripp180901 changed the base branch from feature/k3s-monitoring to main January 6, 2025 10:18
@wtripp180901
Copy link
Contributor Author

rebased from feature/k3s-monitoring onto main so reviewing might be a pain, sorry! Last review was for 1d7dfa3

@wtripp180901
Copy link
Contributor Author

@wtripp180901
Copy link
Contributor Author

persist_hostkeys/nfs changes in separate branch #520

Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly OK! Tested by creating a new cookiecutter environment on CI cloud, following README. Ran:

  • ✔️ site
  • ✔️ hpctests
  • ✔️ can login to ondemand as demo_user
  • ✔️ ondemand shell
  • ❌ can't log in to monitoring - no anonymous auth

Suggest

  • adding environments/skeleton/\{\{cookiecutter.environment\}\}/inventory/group_vars/all/openondemand.yml to set grafana_auth_anonymous: true in new cookiecutter envs
  • adding a note to production docs to review if that is OK

@wtripp180901 wtripp180901 requested a review from sjpb January 8, 2025 16:09
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiiny docs tweak no need to rerun.

@sjpb
Copy link
Collaborator

sjpb commented Jan 8, 2025

✔️ Checked I can login to grafana as demo_user via OOD.
✔️ Checked slurm job dashboard works
✔️ Checked remote desktop worked

Co-authored-by: Steve Brasier <[email protected]>
@wtripp180901 wtripp180901 requested a review from sjpb January 8, 2025 16:54
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb enabled auto-merge (squash) January 8, 2025 16:55
@sjpb sjpb self-requested a review January 8, 2025 16:58
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit dc58a25 into main Jan 8, 2025
0 of 2 checks passed
@sjpb sjpb deleted the feat/skeleton-defaults branch January 8, 2025 16:58
@sjpb sjpb mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with host DNS resolution when configuring services Replace default suffix .invalid with .internal
2 participants