Allow use of Ironic node name as instance name

[priteau]

This can be used in bare metal deployments where we may want the instance hostname to be exactly the same as the node name.

[sjpb]

Are you trying to change the hostname, or just the instance name? If you want to change the former too you'll need to change fqdn (edit; grep for it b/c there's two definitions for instances in the login/compute node groups) in the cloud-init userdata for each instance definition

[priteau]

Are you trying to change the hostname, or just the instance name? If you want to change the former too you'll need to change the fqdn in the cloud-init userdata for each instance definition

In this case, I think both. If the cluster name is foo, but bare metal nodes are already called foo-cpu-01, foo-cpu-02, I want both the instances and the hostnames to be using foo-cpu-01, not foo-foo-cpu-01, while keeping the automatic naming of the login and control VMs.

[sjpb]

Ok, will wait for changes then. I get the intent; I'd note that if you end up moving an ironic node between production/staging to test things, it won't be obvious which cluster is it part of. Although we do set the path to the environment as part of the instance metadata.

[priteau]

Ok, will wait for changes then. I get the intent; I'd note that if you end up moving an ironic node between production/staging to test things, it won't be obvious which cluster is it part of. Although we do set the path to the environment as part of the instance metadata.

I am planning to only use this feature in production. Staging would use the prefix, to make sure nodes can easily be differentiated.