-
Notifications
You must be signed in to change notification settings - Fork 34
Attempt leafcloud build on local disk to compare speed #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
20 min fatimage build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/14197320832/job/39775471558 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think it needs testing on SMS too TBH.
@@ -118,10 +119,16 @@ jobs: | |||
echo $IMAGE_ID > image-id.txt | |||
echo $IMAGE_NAME > image-name.txt | |||
|
|||
- name: Make image usable for further builds | |||
- name: Make image usable for further builds (if signature_verified property exists) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this check here, but not for the same in the fatimage workflow below?
@@ -101,6 +101,7 @@ jobs: | |||
-var "source_image_name=${{ fromJSON(env.FAT_IMAGES)['cluster_image'][matrix.build.source_image_name_key] }}" \ | |||
-var "image_name=${{ matrix.build.image_name }}" \ | |||
-var "inventory_groups=${{ matrix.build.inventory_groups }}" \ | |||
-var "use_blockstorage_volume=true" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this will be for all clouds. Is that OK? If not, I would set it in e.g. environments/.stackhpc/LEAFCLOUD.pkrvars.hcl
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/14333297338
Disk image build works for SMS, so probably okay to set for all clouds
@@ -109,7 +109,7 @@ variable "manifest_output_path" { | |||
|
|||
variable "use_blockstorage_volume" { | |||
type = bool | |||
default = true | |||
default = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're doing this, can you modify docs/image-build.md b/c it currently says vol backed is default. Or, you could just set it to false in CI.
Replaced by #650 |
Leafcloud image builds are volume-backed by default, which causes slow build times
Building images on disk should be quicker for the fatimage build, though volumes are still required for extra-builds