Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct vnic_types var name in skeleton variables #640

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Correct vnic_types var name in skeleton variables #640

merged 2 commits into from
Apr 7, 2025

Conversation

MoteHue
Copy link
Contributor

@MoteHue MoteHue commented Apr 1, 2025

vnic_types is now a mapping from networks to types.

@MoteHue
Correct vnic_types var name in skeleton variables
bb75717 
vnic_types is now a mapping from networks to types.
@MoteHue MoteHue requested a review from a team as a code owner April 1, 2025 15:33
sjpb
sjpb approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, good catch, thanks. Reviewed via grep, appears to fix variable docs to match actual code.

@sjpb sjpb mentioned this pull request Apr 4, 2025
Open
@sjpb sjpb added the documentation Improvements or additions to documentation label Apr 4, 2025
@MoteHue MoteHue merged commit 8ecf4d4 into main Apr 7, 2025
2 checks passed
@MoteHue MoteHue deleted the correct-vnic-types-comment branch April 7, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteau priteau priteau approved these changes

@sjpb sjpb sjpb approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoteHue @priteau @sjpb