Support fixed IP addresses for control node #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable control_ip_address was documented but not implemented. Since we support multiple networks, change it to control_ip_addresses and implement it. Closes #642.
sjpb
reviewed
Apr 4, 2025
| @@ -24,6 +24,12 @@ variable "key_pair" { | |||
| description = "Name of an existing keypair in OpenStack" | |||
| } | |||
|
|
|||
| variable "control_ip_addresses" { | |||
| type = map(string) | |||
| description = "Mapping of networks to fixed IP addresses used by control node" | |||
There was a problem hiding this comment.
Suggested change
| description = "Mapping of networks to fixed IP addresses used by control node" | |
| description = "Mapping of fixed IP addresses for control node, keyed by network name" |
| subnet_id = data.openstack_networking_subnet_v2.cluster_subnet.id | ||
| ip_address = var.control_ip_address | ||
| subnet_id = data.openstack_networking_subnet_v2.cluster_subnet.id | ||
| ip_address = (var.control_ip_addresses != {})? var.control_ip_addresses[each.key]: null |
There was a problem hiding this comment.
Suggested change
| ip_address = (var.control_ip_addresses != {})? var.control_ip_addresses[each.key]: null | |
| ip_address = (var.control_ip_addresses != {}) ? var.control_ip_addresses[each.key] : null |
just makes the ternary clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable control_ip_address was documented but not implemented. Since we support multiple networks, change it to control_ip_addresses and implement it.
Closes #642.