Synchronise yoga with upstream #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
It looks like a raise statement was left in the virtual_size property handler for VMDK, which should have been converted to a log at some point. All the other inspectors return zero for virtual_size if the format does not match or they are unable to parse the data. This converts that raise to a log, and adds a test to make sure we make it far enough in the processing of the complex VMDK format to ensure that behavior. Closes-Bug: #1983279 Change-Id: I0352ab6b2c00055de094ac5902b8d50941d06dcf (cherry picked from commit 199722a) (cherry picked from commit 07f9874)
Change-Id: I21b308c70c14255d29ae2e1feffa2c3fd59fd6eb
|
5 failures, all referring to qemu-img |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of yoga from upstream unmaintained/yoga.