Ci multinode ca choice #1740
Open
Ci multinode ca choice #1740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cherry-pick stackhpc/2024.1 |
Alex-Welsh
requested changes
Jul 7, 2025
There was a problem hiding this comment.
We're planning on making the vault* and openbao* playbooks generic, and use a separate variable to choose between them
See discussion here for details: stackhpc/terraform-kayobe-multinode#93 (comment)
|
I'm putting this PR back to draft while we work on a new solution and Seunghun is away |
seunghun1ee
force-pushed
the
ci-multinode-ca-choice
branch
from
ca400f1 to
93c5748
Compare
seunghun1ee
force-pushed
the
ci-multinode-ca-choice
branch
from
2f2d1d4 to
aeaf3a0
Compare
Alex-Welsh
reviewed
Jul 17, 2025
Comment on lines
+45
to
+47
| consul_bind_interface: "{{ secret_store_bind_interface }}" | ||
| vault_bind_address: "{{ secret_store_bind_address }}" | ||
| vault_api_addr: "{{ secret_store_api_address }}" |
There was a problem hiding this comment.
What's with these new variables?
| - | | ||
| Merged OpenBao playbooks and Hashicorp Vault playbooks. | ||
| They starts with the prefix "secret-store". | ||
| By default, the playbooks are set to be OpenBao playbooks. |
There was a problem hiding this comment.
nit: wording
Suggested change
| By default, the playbooks are set to be OpenBao playbooks. | |
| By default, the playbooks will deploy OpenBao. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The revert at stackhpc/terraform-kayobe-multinode#92 made Epoxy and Caracal ci-multinode to fail because SKC assumes that OpenBao is used as CA.
This allows users to choose which secret store to use as CA.
Related PR: stackhpc/terraform-kayobe-multinode#94