-
Notifications
You must be signed in to change notification settings - Fork 23
Pulp tls update #1743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jackhodgkiss
wants to merge
8
commits into
update-vault-docs-dec-2024
Choose a base branch
from
pulp-tls-update
base: update-vault-docs-dec-2024
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pulp tls update #1743
+90
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The playbook `copy-ca-to-hosts` has been refactored in a couple ways. Firstly, the tasks for installing in either `RHEL` or `Debian` based systems are placed in `blocks`. Secondly both the root and intermediate certificate authority have added here to ensure the full chain is available if required.
This is not required as the pulp certificate can be verified with just `OS-TLS-INT` as the intermediate is provided by the `Pulp` server. Also the `OS-TLS-INT.pem` includes the private key.
Alex-Welsh
reviewed
Jul 15, 2025
@@ -30,7 +30,7 @@ docker_registry: "{{ stackhpc_docker_registry }}" | |||
docker_registry_insecure: "{{ 'https' not in stackhpc_repo_mirror_url }}" | |||
|
|||
# CA of docker registry | |||
#docker_registry_ca: | |||
docker_registry_ca: "{{ kayobe_env_config_path ~ '/openbao/OS-TLS-INT.crt' if pulp_enable_tls | bool else '' }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not default to Bao in this instance. We still have many more people using vault on Caracal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.