refactor: split Dockerfiles into prod and dev files #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… management and development workflow - Updated Dockerfiles for services and libs to use Python 3.13 and 3.11.7. - Introduced separate Dockerfile.dev for development environments with optimized caching. - Enhanced dependency installation logic in Dockerfiles to streamline dev and prod setups. - Updated Poetry version to 2.1.3 across all services and libs. - Refined pyproject.toml files to include TestPyPI sources and group dependencies for better management. - Improved logging setup in Dockerfiles for better runtime diagnostics.
- Moved test dependencies to a dedicated group and added pytest and coverage. - Created a separate lint group with flake8 and related plugins. - Added debugpy and rag-core libraries to the dev group. - Updated production dependencies for rag-core libraries to version 2.2.1.
- Updated `pyproject.toml` and `poetry.lock` files to enforce `setuptools` version to be less than 80.9 in multiple services. - Adjusted per-file ignores for linting in `admin-backend` and `document-extractor`. - Streamlined Dockerfiles for `document-extractor`, `rag-backend`, and `mcp-server` to improve build efficiency and user permissions. - Ensured consistent formatting in dependency declarations across services. - Updated versioning for `pdfextractor_server` to 2.2.1. - Added minimal library structures in Dockerfiles to facilitate local package recognition by Poetry.
- Moved `pytest` and `pytest-asyncio` to a new test dependency group in `rag-core-lib`. - Added `coverage` to the test dependencies in `rag-core-lib`. - Created a separate lint dependency group in `rag-core-lib` and included `flake8` and related packages. - Updated markers in `poetry.lock` for better platform compatibility. - Removed `pytest-asyncio` from the `rag-backend` dependencies and adjusted its group to only include `test`.
… prod-local group for development
… Dockerfile cleanup and user permissions; adjust pyproject.toml for local dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the development and build workflows for both the backend services and Python libraries. The main changes include a clearer separation between development and production Docker builds, enhanced configuration for local development via Tilt, and improved dependency management and testing setup for Python libraries. These updates streamline live development, testing, and linting processes, making them more reliable and easier to maintain.
Build and workflow improvements:
Tiltfile, allowing dynamic switching betweenDockerfile.dev(for live code updates and fast iteration) and productionDockerfile(for optimized builds). Also updated Docker ignore lists for more targeted builds. [1] [2] [3] [4] [5] [6] [7]Dockerfile.devfor service builds during linting and testing, removed unnecessary build arguments, and set Python version to 3.13 for consistency. [1] [2] [3] [4]Python library dependency and testing enhancements:
test,lint, anddevdependencies, addedsetuptools <80.9for compatibility, and updated library versions. Also improvedpytestconfiguration for better logging and path setup. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Docker build improvements for Python libraries:
libs/Dockerfileto use Poetry 2.1.3, improved conditional installation logic for dev/test/lint dependencies, and ensured correct installation of shared dependencies for interdependent libraries.Frontend workflow fixes:
npm installruns before frontend linting and testing in Tilt, and expanded dependency tracking for these local resources. [1] [2]Dependency version updates:
fasttextto a stable release and updating internal library versions to 2.2.1. [1] [2] [3] [4]Let me know if you want to walk through any of these changes in detail or discuss how they impact your local development workflow!