This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Use 'B' instead of 'b' to parse/build char value. #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
pickle.load
raisesOverflowError
if loaded content includesPyFrameObject
, whosef_executing
is set toSLP_FRAME_EXECUTING_INVALID
, i.e.-1
.Solution:
How to reproduce this issue:
OverflowError
unexpectedly.Details:
f_executing
inPyFrameObject
is declared aschar
, which might be signed depending on implementation.Therefore, 'B' should be specified when
Py_BuildValue
andPyArg_ParseTuple
is called.f_executing
is set toSLP_FRAME_EXECUTING_INVALID
,PyArg_ParseTuple
inframe_setstate
inStackless\pickling\prickelpit.c
raises OverflowError.This is raised in
convertsimple
inPython\getargs.c
becauseSLP_FRAME_EXECUTING_INVALID
is less than0
.