Skip to content

Conversation

kantord
Copy link
Member

@kantord kantord commented Aug 29, 2025

Before

Record_select-area_20250901125436.mp4

After

Record_select-area_20250901125150.mp4

@kantord kantord requested a review from peppescg September 1, 2025 11:02
@kantord kantord marked this pull request as ready for review September 1, 2025 11:02
@Copilot Copilot AI review requested due to automatic review settings September 1, 2025 11:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the navigation system to improve group navigation by implementing a proper route-based approach. The main index route now redirects to the default group, and a new dedicated group route handles group-specific content.

Key changes:

  • Replace query parameter-based group navigation with proper route parameters
  • Introduce dedicated /group/$groupName route for group-specific functionality
  • Update components to use route parameters instead of search parameters for current group identification

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
renderer/src/routes/index.tsx Simplified to redirect to default group route
renderer/src/routes/group.$groupName.tsx New dedicated route for group functionality with all original logic
renderer/src/routes/tests/index.test.tsx Removed tests (moved to group route)
renderer/src/routes/tests/index.groups.test.tsx Updated to use new group route test setup
renderer/src/route-tree.gen.ts Added new group route to generated route tree
renderer/src/features/mcp-servers/components/groups-manager/index.tsx Updated to use route params instead of search params
renderer/src/features/mcp-servers/components/groups-manager/group-list.tsx Updated navigation to use route params
renderer/src/features/mcp-servers/components/groups-manager/tests/add-group-workflow.test.tsx Updated test router for new group route

Copy link
Collaborator

@peppescg peppescg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the video seems work as expected 🚀
I left a couple of comments

@kantord kantord enabled auto-merge (squash) September 1, 2025 11:39
@kantord kantord merged commit 090d446 into main Sep 1, 2025
23 checks passed
@kantord kantord deleted the group-fixes branch September 1, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants