-
Notifications
You must be signed in to change notification settings - Fork 5
fix: smooth navigation between groups #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the navigation system to improve group navigation by implementing a proper route-based approach. The main index route now redirects to the default group, and a new dedicated group route handles group-specific content.
Key changes:
- Replace query parameter-based group navigation with proper route parameters
- Introduce dedicated
/group/$groupName
route for group-specific functionality - Update components to use route parameters instead of search parameters for current group identification
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
renderer/src/routes/index.tsx | Simplified to redirect to default group route |
renderer/src/routes/group.$groupName.tsx | New dedicated route for group functionality with all original logic |
renderer/src/routes/tests/index.test.tsx | Removed tests (moved to group route) |
renderer/src/routes/tests/index.groups.test.tsx | Updated to use new group route test setup |
renderer/src/route-tree.gen.ts | Added new group route to generated route tree |
renderer/src/features/mcp-servers/components/groups-manager/index.tsx | Updated to use route params instead of search params |
renderer/src/features/mcp-servers/components/groups-manager/group-list.tsx | Updated navigation to use route params |
renderer/src/features/mcp-servers/components/groups-manager/tests/add-group-workflow.test.tsx | Updated test router for new group route |
renderer/src/features/mcp-servers/components/groups-manager/group-list.tsx
Show resolved
Hide resolved
renderer/src/features/mcp-servers/components/groups-manager/group-list.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the video seems work as expected 🚀
I left a couple of comments
Before
Record_select-area_20250901125436.mp4
After
Record_select-area_20250901125150.mp4