Refactor deploymentForMCPServer for platform detection. (#1063) (#1285) #1500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoddieKieley
force-pushed
the
issue1063-refactor-deploymentForMCPServer
branch
from
e94903e to
2961795
Compare
jhrozek
reviewed
Aug 21, 2025
jhrozek
reviewed
Aug 21, 2025
jhrozek
reviewed
Aug 21, 2025
jhrozek
reviewed
Aug 21, 2025
|
It will be so nice to do all of this code in one place when we implement #1497 😄 |
RoddieKieley
force-pushed
the
issue1063-refactor-deploymentForMCPServer
branch
from
2961795 to
f17cb67
Compare
|
@ChrisJBurns What's the relative order of operations here with respect to #1497? Wondering if we can get this in prior, or if we need to do #1497 first then update here? What do you think? |
dmartinol
reviewed
Aug 25, 2025
dmartinol
reviewed
Aug 25, 2025
… (stacklok#1285) Signed-off-by: Roddie Kieley <[email protected]> Co-authored-by: Cursor claude-4-sonnet <[email protected]>
RoddieKieley
force-pushed
the
issue1063-refactor-deploymentForMCPServer
branch
from
f17cb67 to
d4e8cce
Compare
jhrozek
approved these changes
Aug 28, 2025
JAORMX
pushed a commit
that referenced
this pull request
Aug 29, 2025
… (#1500) Signed-off-by: Roddie Kieley <[email protected]> Co-authored-by: Cursor claude-4-sonnet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR#1301 for #1285 set the security context for ProxyRunner deployments without taking into account kubernetes platform differences and detection as was introduced for #1063 via PR#1253.
This addresses that concern by refactoring the code dealing with security context, encapsulating that specific functionality better than was previously done for either #1063 or #1285.
Also while this should not directly impact #1483, assuming the operator was running it would have required manual changes to the MCPServer instances Deployment to remove the incorrectly set runAsUser, runAsGroup, and fsGroup values once it was so mentioning here.
I am marking this as Draft; while it works well here there is a good bit of code addition and change so having @jhrozek and/or @ChrisJBurns take a look as a follow up to #1063 is probably in order.
Feel free to modify/update as require and feedback welcome.